aminghadersohi commented on PR #41923: URL: https://github.com/apache/superset/pull/41923#issuecomment-5005313412
Follow-up on the [2026-07-15 Bito review run #f0a467](https://github.com/apache/superset/pull/41923#issuecomment-4984613582) — addressing all 6 items (3 "Additional Suggestions" + 3 "Filtered by Review Rules"): **Fixed (pushed in 480a59b):** - `dataset/schemas.py` — missing test for the `search`+`filters` mutual-exclusion validator on `ListDatasetsRequest`. Added `test_list_datasets_search_and_filters_conflict_validation`, mirroring the existing per-domain tests on chart/theme/query/saved_query. - `annotation_layer/schemas.py:105` (`AnnotationList(PaginatedResponse[ColumnOperator])`, flagged as "wrong generic type parameter") — I initially agreed and changed this to `PaginatedResponse[AnnotationFilter]` to match every other domain's convention, but that broke 5 tests: `list_layer_annotations` prepends a synthetic `ColumnOperator(col="layer_id", ...)` scoping filter to `filters_applied`, and `"layer_id"` isn't in `AnnotationFilter`'s `col` Literal (only `"short_descr"` is). Reverted to `ColumnOperator` and added a comment explaining why this one domain is a deliberate exception to the pattern. **No change needed:** - `list_charts.py:64` (`_DEFAULT_LIST_CHARTS_REQUEST = ListChartsRequest()` module-level default) — this is the established convention used identically across all 13 other `list_*` tools (`list_dashboards.py`, `list_datasets.py`, `list_tags.py`, etc.), predating this PR. Singling out `list_charts` for inlining would be inconsistent. - `theme/schemas.py:106` (`ThemeList` missing a docstring) — none of the 14 `*List(PaginatedResponse[...])` response classes across the MCP service have docstrings (`ChartList`, `DashboardList`, `ReportList`, etc.); the shape is documented on the shared `PaginatedResponse` base. Adding one only to `ThemeList` would be inconsistent with its siblings. - `chart/schemas.py:683` ("missing runtime fields on response") — verified `ChartList(PaginatedResponse[ChartFilter])`'s effective field set (`count`, `total_count`, `page`, `page_size`, `total_pages`, `has_previous`, `has_next`, `columns_requested/loaded/available`, `sortable_columns`, `filters_applied`, `pagination`, `timestamp`) is identical to the pre-refactor `ChartList(BaseModel)` on `master` — nothing was dropped in the dedup. - `middleware.py:400-419` (CWE-1109 stale documentation reference) — this is the `PrivateToolMiddleware` deletion; grepped the repo for any remaining reference to `PrivateToolMiddleware` or the `"private"` tool tag it enforced and found none outside of an unrelated docstring in `server.py`. The deletion is clean. Re-verified: 0 unresolved review threads, 2,976 `tests/unit_tests/mcp_service/` tests pass, pre-commit clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
