villebro commented on a change in pull request #8448: Add UI-only database
configuration method for extended authorization scenarios
URL:
https://github.com/apache/incubator-superset/pull/8448#discussion_r338887549
##########
File path: superset/models/core.py
##########
@@ -748,6 +748,9 @@ class Database(Model, AuditMixinNullable, ImportMixin):
"""
),
)
+ encrypted_extra = Column(
+ EncryptedType(Text, config.get("SECRET_KEY")), nullable=True
+ )
Review comment:
Nit: as per #8409, config variables are assumed to always be set. So this
should be changed to ...`config["SECRET_KEY"]`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
