aminghadersohi commented on PR #41606:
URL: https://github.com/apache/superset/pull/41606#issuecomment-5005439744
## Bot review sweep (2026-07-17)
Addressed the 13 codeant-ai type-hint nits and the two substantive
codeant-ai findings from the post-rebase review round (commit range
`e24e856..3117ce3`) — replies inline on each thread, all fixed in cde36518a5.
Also verified bito-code-review's two "Additional Suggestions" from that same
run:
- **`certification_details` bool-coercion** (`schemas.py`): checked directly
against this repo's pydantic version — a `bool` passed to a plain `str | None`
field raises `ValidationError` (`Input should be a valid string`), it does not
coerce to `"True"`/`"False"`. No `reject_bool_*`-style guard needed here; that
pattern is reserved for `int | str` identifier fields where `bool`'s `int`
subclassing is the actual risk.
- **Duplicate `mock_auth` fixture** (`conftest.py`): there is exactly one
`mock_auth` fixture, defined once in
`tests/unit_tests/mcp_service/dashboard/tool/conftest.py`. None of the three
governance test files redefine it — `test_manage_dashboard_owners.py` nests a
`with patch("superset.security_manager.raise_for_editorship", ...)` inside one
test body to override the auth fixture's no-op for that single test, which is a
normal nested-patch, not a second fixture definition.
Both check out as false positives; no code change needed for either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
