rusackas commented on PR #35662: URL: https://github.com/apache/superset/pull/35662#issuecomment-5005969487
Thanks for the update @nicob3y! CI's failing now because `test_dataset_macro` still only mocks `DatasetDAO.find_by_id`. The new string-path assertions hit an unmocked `get_table_by_catalog_schema_and_name` and just compare against a MagicMock instead of the real dataset. Bito flagged this above. Korbit's `multiple responsibilities` thread is also still open and worth assessment before we merge. Holler if you want help with any of the above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
