rusackas commented on PR #42018:
URL: https://github.com/apache/superset/pull/42018#issuecomment-5005983086
Thanks @MallikarjunaReddyN!
This `.ant-tabs-tabpane { display: flex; flex-direction: column }` rule was
added in #21282 specifically to keep the header/pagination pinned while
multi-query 'View as Table' results scroll. Removing it outright fixes the
overlap you're showing, but did you check the original scroll-behind-header bug
hasn't come back for the multi-query case?
The shared `Tabs` component only applies `height: 100%` to
`.ant-tabs-tabpane` when `fullHeight` is passed, and it isn't here, so
nothing's replacing what you're deleting.
TESTING INSTRUCTIONS is blank on the PR template, and there's no test
covering scroll behavior either way, Also needs a rebase, it's conflicting
agianst `master` now. Holler if I can help get this across the finish line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
