rusackas commented on PR #42088: URL: https://github.com/apache/superset/pull/42088#issuecomment-5006022898
Thanks for pushing this forward! In `buildQuery.ts` the new `percent_metric_calculation: 'all_records'` extra query is spread from `queryObject` before `interactiveGroupBy`. The AG Grid column filters, and the search filter get merged into it later in the same function, so that query runs with a stale filter set. The percent-of-total denominator would be wrong for anyone filtering interactively while that mode is on. Codeant's threads flag the migration processor ignoring `extra_form_data.time_compare`/`time_grain_sqla` overrides, and the client-view dedup signature in `AgGridTable/index.tsx` missing row-value changes, which would be worth assessing since they'd make migrated/exported data diverge from what V1 showed. In general, lots of bot comments open/unresolved... let me know if I can help close 'em out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
