rusackas commented on PR #42120: URL: https://github.com/apache/superset/pull/42120#issuecomment-5006225514
Thanks Elizabeth! LGTM on the approach, and thanks for the tests. One nit: since `validate_screenshot_image` already returns "empty" for falsy bytes, is the `image and` in `compute_and_cache`'s check redundant, or am I missing something? Will take another look once CI's green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
