philipljh commented on PR #42114: URL: https://github.com/apache/superset/pull/42114#issuecomment-5006417163
> Thanks @philipljh, LGTM! > > Curious though if `helm unittest` actually runs anywhere in CI, or if `tests/init_containers_test.yaml` only gets exercised locally? Looks like `superset-helm-lint.yml` just runs `ct lint` today, but that's true of the whole `tests/` directory already, so not blocking this one necessarily. `superset-helm-lint.yml` only does ct list-changed + ct lint, and the `tests/` suite looks like it has only ever been a local helm unittest thing. Would be happy to wire a helm unittest step into the lint workflow as a separate follow-up, if that's worth doing 😄 . Cheers! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
