rusackas commented on PR #41714:
URL: https://github.com/apache/superset/pull/41714#issuecomment-5006671259

   Found a bug while poking at this: the Paired t-test chart 500s with 
"Datetime column not provided...". Turns out its `buildQuery` sends 
`is_timeseries`, so the backend wants a datetime column, but the migrated 
control panel dropped its time section entirely, so there is no way to even 
supply one (and nothing for the panel to flag as missing).
   
   The other timeseries charts kept theirs (`rose` via 
`sections.legacyTimeseriesTime`, `horizon` with an explicit 
`granularity_sqla`), so `paired_ttest` was the odd one out. Pushed a fix to the 
branch (ef6f684) adding `sections.legacyTimeseriesTime` back, plus a little 
controlPanel test to guard it. `granularity_sqla` defaults to the dataset main 
datetime col, so it should render out of the box now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to