rusackas commented on PR #42097: URL: https://github.com/apache/superset/pull/42097#issuecomment-5008877011
One question before merging: unmounting `TableView` wipes any user-applied sort and scroll position every time the window resizes, on every TimeTable on screen. Acceptable tradeoff, or worth keeping it mounted and just gating updates instead? Also, with the conditional render, the `hideTable`/`display: none` on the wrapper looks redundant now, and the description says 500ms while `RESIZE_DEBOUNCE_MS` is 300. Might be worth aligning these? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
