rusackas commented on code in PR #41396:
URL: https://github.com/apache/superset/pull/41396#discussion_r3607155308
##########
helm/superset/templates/_helpers.tpl:
##########
@@ -685,6 +685,13 @@ TALISMAN_CONFIG = {
{{- define "superset.initScript" -}}
#!/bin/sh
set -eu
+{{- if dig "istio" "terminateSidecarOnExit" false .Values.init }}
+# Notify the Istio pilot-agent sidecar to exit when this script completes
+# (whether successfully or via `set -e`), so that the Job can reach the
+# Completed state instead of hanging on a still-running envoy-proxy.
+# See https://github.com/apache/superset/issues/25798
+trap 'rc=$?; curl -fsS -m 5 -X POST {{ dig "istio" "quitEndpoint"
"http://localhost:15020/quitquitquit"; .Values.init | quote }} >/dev/null 2>&1
|| true; exit $rc' EXIT
Review Comment:
Good catch, the value was double-quoted right inside the trap string, and
the whole thing gets re-parsed when the trap fires, so `$()`/backticks in it
would actually run. Pushed a fix that stashes it in a single-quoted shell var
first and references that instead, so nothing in there gets interpreted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
