bito-code-review[bot] commented on PR #42154:
URL: https://github.com/apache/superset/pull/42154#issuecomment-5009179135
<!-- Bito Reply -->
The flagged issue is correct. In
`superset-frontend/plugins/plugin-chart-echarts/src/components/Echart.tsx`, the
`LOCALE_LOADERS` map uses the key `SI` for Slovenian, but the application
normalizes the locale code to `SL` before lookup. This mismatch prevents the
Slovenian locale from being loaded, causing ECharts to fall back to English.
To resolve this, update the key in `LOCALE_LOADERS` from `SI` to `SL` to
match the normalized locale code.
**superset-frontend/plugins/plugin-chart-echarts/src/components/Echart.tsx**
```
RU: () => import('echarts/i18n/langRU.js'),
SL: () => import('echarts/i18n/langSL.js'),
SV: () => import('echarts/i18n/langSV.js'),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
