sadpandajoe opened a new pull request, #42156:
URL: https://github.com/apache/superset/pull/42156
### SUMMARY
Following #39925, which collapsed the historical `/superset/` prefix off all
canonical views (`Superset.route_base = ""`), a few hardcoded URL literals
still
emit the old `/superset/...` form and rely on the closed-set 308 redirect
shim
(scheduled for removal at EOL 5.0.0). This points them at the canonical paths
directly so they no longer depend on the shim:
- `getURIDirectory()` in the deck.gl and legacy nvd3 chart plugins:
`/superset/explore_json/` → `/explore_json/`
- The filter-box → native-filter migration helper's generated markdown link:
`/superset/slice/{id}/` → `/slice/{id}/`
The migration-helper change only affects **future** upgrade runs — markdown
already
written to previously-migrated dashboards is untouched (and remains
shim-covered
until 5.0.0). No new migration is introduced; this only edits shared helper
text.
`/explore_json/` and `/slice/<int>/` are both live routes on master.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A — internal URL construction; no visual change.
### TESTING INSTRUCTIONS
- deck.gl / nvd3: build a chart of the relevant type and confirm data
requests go to
`/explore_json/...` directly (no `/superset/` prefix, no 308 redirect hop).
- Migration: run the filter-box → native-filter migration on a dashboard
containing a
filter-box chart; confirm the generated markdown links to `/slice/<id>/`.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
