prathamesh04 commented on PR #42155:
URL: https://github.com/apache/superset/pull/42155#issuecomment-5009526121
Thanks for the reviews. Updated the test in the latest commit to address the
feedback:
- **Before**: Mounted `DataTable` directly with plain `<td>` cell renderers
that had no click side effects — clicking a cell did nothing, so the test
passed even without the fix
- **After**: Mounts `TableChart` with cross-filtering enabled
(`emitCrossFilters: true`). The test:
1. Renders 30 rows across 3 pages (page_length: 10)
2. Navigates to page 2, clicks a cell (triggers `setDataMask` via
cross-filter)
3. Re-renders with filtered data (15 rows) simulating a dashboard filter
response
4. Verifies the page stays on page 2 after the data re-render
This exercises the actual regression path where cross-filter-triggered data
re-renders would reset pagination if `autoResetPage` were not set to `false`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
