rusackas commented on PR #41913: URL: https://github.com/apache/superset/pull/41913#issuecomment-5009680852
Thanks for tracking this down! One thing before I can approve, though. In `useSchemas`/`useCatalogs` (schemas.ts/catalogs.ts), `originalArgs` is shared across the whole cache entry since `serializeQueryArgs` strips `forceRefresh` from the key. So if the refresh button is what last touched that entry and hit the OAuth wall, `originalArgs.forceRefresh` stays true on that entry, and the new `!originalArgs?.forceRefresh` guard silently skips firing onSuccess/onError on the invalidateTags-driven refetch after the redirect. Banner stays stuck, same bug this PR is fixing, just from the refresh-button path instead of the initial load. Probably worth a test covering that path too. Holler if you want a hand in all that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
