john-bodley edited a comment on issue #8450: [SIP-15] Making client time UTC URL: https://github.com/apache/incubator-superset/pull/8450#issuecomment-546226319 @villebro I agree regarding adding a section to `UPDATING.md`. The timezone logic is possibly more nuances especially if we’re talking about non-explicit timezone formats, i.e., not epoch which is in reference to UTC. There are three different clocks: 1. The database engine 2. The Superset server 3. The Superset client in addition to possible timezone encoding in the data. Unless ISO 8601 times are encoded with the timezone (which can be specified in the time range picker) the time logic can become quite complex especially if all three clocks are not using the same timezone. Currently for the time range picker absolute times are specified using the client clock (or per this PR use UTC as the local time) without a designated timezone. Similarly relative times are evaluated on the Superset server using the server clock without a designated timezone. When the query is run the times are in reference to the local time of the database engine. This can get quite messy if the timezones differ as it’s not apparent (especially for relative times) what the reference point is.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
