rusackas commented on code in PR #42193:
URL: https://github.com/apache/superset/pull/42193#discussion_r3608515061
##########
superset/charts/data/api.py:
##########
@@ -495,13 +495,19 @@ def _send_chart_response( # noqa: C901
result, form_data, filename=filename,
expected_rows=expected_rows
)
+ export_filename = filename or
self._get_default_export_filename(form_data)
Review Comment:
Confirmed — the frontend only appends `.csv` to `filename` on the
streaming-export path, but the backend independently recomputes
`_should_use_streaming`, so a mismatch can route that already-extensioned name
into the non-streaming branch and double it. Fixed by stripping a matching
trailing extension before it hits `generate_download_headers`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
