rusackas commented on PR #40084: URL: https://github.com/apache/superset/pull/40084#issuecomment-5011605884
Thanks for running this through Codex, @kgabryje! I don't think the deletion claim holds up though. `on_any_event` has never fired a reload on `FileDeletedEvent`, not in this version and not in the original watcher either (see 965ede7b04), the isinstance check has always been limited to Created/Modified/Moved. Skipping delete-only events is intentional since webpack deletes old chunks right before writing the new ones, so it's the following create/modify that fires the reload. There's a test for it (`test_delete_evicts_hash_entry`). On the atomic dist rename, I spun up watchdog locally and renaming the whole directory does emit a `FileMovedEvent` per nested file, confirmed on macOS and via watchdog's `generate_sub_moved_events` on the inotify backend, so `_handle_moved` does fire for that case too. Applied the `Path.touch()` nit though, thanks for that one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
