willbarrett opened a new pull request #8454: Wbarrett/config not config get URL: https://github.com/apache/incubator-superset/pull/8454 ### CATEGORY Choose one - [ ] Bug Fix - [ ] Enhancement (new features, refinement) - [X] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> As pointed out here https://github.com/apache/incubator-superset/pull/8409/files#diff-6a3371457528722a734f3c51d9238c13R482 we no longer want to use the `config.get` format, but instead assume that all configuration options are set. This PR alters all existing usages of `config.get` to the `config[]` syntax. Note that this will cause errors if those configuration options are not provided. In order to get the system running again, I had to set the following configuration options locally: ```python # Stuff that needs defaulting ENABLE_CHUNK_ENCODING = False FEATURE_FLAGS = {} EVENT_LOGGER = None SQLALCHEMY_CUSTOM_PASSWORD_STORE = None QUERY_LOGGER = None FAB_ADD_SECURITY_VIEWS = True SUPERSET_LOG_VIEW = True HTTP_HEADERS = {} ``` I'm somewhat concerned about the effect of merging this in terms of stability, so I'm looking for feedback from the community, especially @villebro who clued me in to the preferred approach in the first place. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TEST PLAN <!--- What steps should be taken to verify the changes --> - Run CI - Click around locally - Request feedback from the community ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS @villebro @mistercrunch @dpgaspar
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
