rusackas commented on PR #42143: URL: https://github.com/apache/superset/pull/42143#issuecomment-5012324185
Thanks for tackling this, @justinpark. `AppContent` now requires `layoutPortalNode` as a prop, but `App` still renders `<AppContent />` with nothing passed, so `OutPortal` gets `undefined` and the layout can't render. Bito and Codeant's threads both flag this, but it's still unresolved. That's also why `lint-frontend`, `playwright-tests`, and `cypress-matrix` are all red here, not unrelated flakiness. Pass `layoutPortalNode` through to `AppContent` and those should clear up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
