rusackas commented on PR #39918: URL: https://github.com/apache/superset/pull/39918#issuecomment-5013091556
Thanks for scoping this down to just `schema`, that resolves the `database_id` no-op I flagged. Still waiting on @betodealmeida (or perhaps @villebro / @sadpandajoe) for the actual question though: was requiring database/schema on datasets load-bearing for schema-scoped permissions, or is nulling it out safe here? Don't want to merge past that without a reassuring answer. Separately, `master`'s drifted enough since this branch was opened that the translation-regression check is failing on unrelated strings, this'll need a rebase regardless. I'll see about tackling that part now... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
