villebro commented on a change in pull request #8454: Use `config[]` not
`config.get()`
URL:
https://github.com/apache/incubator-superset/pull/8454#discussion_r339294276
##########
File path: superset/sql_lab.py
##########
@@ -400,7 +400,7 @@ def execute_sql_statements(
)
cache_timeout = database.cache_timeout
if cache_timeout is None:
- cache_timeout = config.get("CACHE_DEFAULT_TIMEOUT", 0)
+ cache_timeout = config["CACHE_DEFAULT_TIMEOUT"]
Review comment:
I wonder what the point of defaulting to 0 was here. I can only assume it is
a relic from long ago.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
