rusackas commented on PR #36882: URL: https://github.com/apache/superset/pull/36882#issuecomment-5018019763
Thanks for taking a crack at this @vighneshtule, and sorry it sat as long as it did. The codebase has since moved in the opposite direction... #39778 deliberately made Clear All stage its changes until Apply, since dispatching immediately broke required-filter validation and the stage/apply UX. A rebase here would mostly just revert that, so I'm going to close this one out as superseded. If the immediate-apply idea in #36876 wins out design-wise, happy to review a fresh take built on the new model. Thanks for this and future contributions! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
