rusackas commented on PR #39257: URL: https://github.com/apache/superset/pull/39257#issuecomment-5018525202
Still conflicting with `master`, so this can't go anywhere until it's rebased. Also the `canEdit` prop on `TextAreaControl` in `DatasourceEditor.tsx` is still there (both metrics and calculated columns expression renderers). It's not a real prop on that component, just swallowed by its `[key: string]: unknown` index signature, so it's dead weight left over from copy-pasting `EditableTitle`. I asked for this twice now (April and June) and it's still in the diff. @Vikash-Kumar-23 I'll see about a rebase, but then if you can drop `canEdit` and ping me, I'll take another pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
