rusackas commented on PR #42087: URL: https://github.com/apache/superset/pull/42087#issuecomment-5018546025
Codeant's thread on `models_test.py` is still open, and it seems right. `test_get_sqla_col_falls_back_when_stored_expression_unparseable` never asserts `validate_adhoc_subquery` got called, so it'd still pass even if the query-time gate got ripped out entirely. Mind adding the same `spy.assert_called_once()` the two tests above it use? Otherwise this looks like a solid continuation of #40392. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
