rusackas commented on PR #40815: URL: https://github.com/apache/superset/pull/40815#issuecomment-5018548553
One thing I'm curious about: does the embedded guest role actually get `can_get_column_values` on `Datasource`? That's a distinct permission from what Public/Gamma get by default, so if it's missing, the exact embedded case this targets would just render a blank grid instead of leaking values, which is safe but might mean the fix doesn't actually help out of the box. Worth confirming before merge. Also, `babel-extract` is red on the new translatable string, looks like it needs `./scripts/translations/babel_update.sh`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
