john-bodley commented on a change in pull request #8454: Use `config[]` not `config.get()` URL: https://github.com/apache/incubator-superset/pull/8454#discussion_r339306108
########## File path: superset/config.py ########## @@ -522,7 +522,7 @@ class CeleryConfig(object): SMTP_MAIL_FROM = "[email protected]" if not CACHE_DEFAULT_TIMEOUT: - CACHE_DEFAULT_TIMEOUT = CACHE_CONFIG.get("CACHE_DEFAULT_TIMEOUT") # type: ignore + CACHE_DEFAULT_TIMEOUT = CACHE_CONFIG["CACHE_DEFAULT_TIMEOUT"] # type: ignore Review comment: Do we still need the `# type: ignore`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
