hy144328 commented on PR #42212: URL: https://github.com/apache/superset/pull/42212#issuecomment-5022419283
Looks great. It is noteworthy that the PR does not manually add `SavedQuery` to the session anywhere after the removal of `cascade_backrefs`. I have double-checked all 13 or so references to the `SavedQuery()` constructor. They are already all followed by a `db.session.add()`. So it is as simple as it looks, and I think the PR is good to go. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
