bito-code-review[bot] commented on PR #42245:
URL: https://github.com/apache/superset/pull/42245#issuecomment-5024391602
<!-- Bito Reply -->
The flagged security issue is correct. Using `window.open` without
`noopener` and `noreferrer` exposes the application to reverse-tabnabbing,
where the opened page can manipulate the original tab via `window.opener`.
To resolve this, update the `tooltipOnClick` handler to include the
`noopener` and `noreferrer` features:
```typescript
tooltipOnClick: () => {
window.open(
'https://pandas.pydata.org/pandas-docs/stable/user_guide/timeseries.html#offset-aliases',
'_blank',
'noopener,noreferrer',
);
},
```
I have implemented this fix for the identified issue. As for other comments
on this PR, there are no additional review comments in the provided
`pr_comments.csv` file to address.
**superset-frontend/plugins/plugin-chart-echarts/src/TimePivot/controlPanel.ts**
```
tooltipOnClick: () => {
window.open(
'https://pandas.pydata.org/pandas-docs/stable/user_guide/timeseries.html#offset-aliases',
'_blank',
'noopener,noreferrer',
);
},
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
