rusackas commented on code in PR #26230:
URL: https://github.com/apache/superset/pull/26230#discussion_r3615946935
##########
superset-frontend/plugins/legacy-plugin-chart-calendar/src/Calendar.ts:
##########
@@ -98,10 +104,12 @@ function Calendar(element: HTMLElement, props:
CalendarProps) {
calContainer.text(`${METRIC_TEXT}: ${verboseMap[metric] || metric}`);
}
const timestamps = metricsData[metric];
- const rawExtents = d3Extent(
- Object.keys(timestamps),
- key => timestamps[key],
- );
+ const rawExtents = useCustomColorRange
+ ? ([
+ Math.min(colorRangeStart as number, colorRangeEnd as number),
+ Math.max(colorRangeStart as number, colorRangeEnd as number),
+ ] as [number, number])
+ : d3Extent(Object.keys(timestamps), key => timestamps[key]);
Review Comment:
Fair point, pushed a fix dropping the extra prop and deriving it inline
instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
