etr2460 commented on issue #8454: Use `config[]` not `config.get()` URL: https://github.com/apache/incubator-superset/pull/8454#issuecomment-546663522 +1 to @john-bodley's point, if switching from `get` to `[]` causes errors because the variables weren't defined in the config, then I think we should define defaults in the `config.py` file. Also, in terms of typing, once we move to python 3.8, I think defining a Config type as a `TypedDict` (https://www.python.org/dev/peps/pep-0589/) should be really helpful here, as it'll catch any config vars not set. I think this is an awesome change overall though, thanks for taking it on!
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
