sadpandajoe opened a new pull request, #42249:
URL: https://github.com/apache/superset/pull/42249

   ### SUMMARY
   
   Fix the master-only tagged-image Compose sanity check after Python 3.10 
support
   was removed in #42045.
   
   `docker-compose-image-tag.yml` inherited `DEV_MODE=true` and bind-mounted the
   current `superset-core` over the published `latest-dev` image's editable
   package. That made the Python 3.10.20 image attempt to install current 
source,
   which requires Python 3.11, and failed master run
   https://github.com/apache/superset/actions/runs/29754426258.
   
   Tagged-image services now use their bundled packages by forcing
   `DEV_MODE=false` and removing the host core mount. The regression test covers
   every service using the tagged Superset image, and the change detector routes
   this Compose file through Python unit tests so future Compose-only pull
   requests run that coverage.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Not applicable; CI and Docker Compose configuration only.
   
   ### TESTING INSTRUCTIONS
   
   ```bash
   PYTHONPATH=. pytest -q --noconftest \
     tests/unit_tests/scripts/change_detector_test.py \
     tests/unit_tests/docker_compose_image_tag_test.py
   
   docker compose -f docker-compose-image-tag.yml config --quiet
   pre-commit run
   ```
   
   The two focused test files pass (6 tests), the resolved Compose configuration
   has four tagged-image services with `DEV_MODE=false` and no
   `/app/superset-core` mount, and every applicable staged-file pre-commit hook
   passes.
   
   ### ADDITIONAL INFORMATION
   
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to