rusackas commented on PR #38451: URL: https://github.com/apache/superset/pull/38451#issuecomment-5024919372
@MelikHajlawi thanks for cleaning up the console.logs and indentation — the fix logic and tests look right to me now. This is still showing as conflicting, and heads up: master's `transformProps.ts` grew `displayLabelMap`/`displayLabelMapB` (around line 477) that your truncate branches will need to populate with the truncated name, so the rebase isn't purely mechanical. Once it's green against master I think this is mergeable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
