etr2460 commented on a change in pull request #8455: [Datasource Editor] A few
small UI changes in modal to prevent accidental edits
URL:
https://github.com/apache/incubator-superset/pull/8455#discussion_r339325752
##########
File path:
superset/assets/src/explore/components/controls/DatasourceControl.jsx
##########
@@ -116,23 +118,16 @@ class DatasourceControl extends React.PureComponent {
render() {
const { menuExpanded, showChangeDatasourceModal, showEditDatasourceModal }
= this.state;
- const { datasource, onChange, onDatasourceSave, value } = this.props;
+ const { datasource, onChange, onDatasourceSave, value,
canChangePhysicalTable } = this.props;
return (
<div>
<ControlHeader {...this.props} />
<div className="btn-group label-dropdown">
- <OverlayTrigger
- placement="right"
- overlay={
- <Tooltip id={'error-tooltip'}>{t('Click to edit the
datasource')}</Tooltip>
Review comment:
I think we should keep this, but on click it should bring up the `Change
Datasource` dialog instead since that's a pretty common action. The tooltip
would then be changed to say `Click to change the datasource` or `Click to
select a datasource` or something like that
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
