codeant-ai-for-open-source[bot] commented on code in PR #35218:
URL: https://github.com/apache/superset/pull/35218#discussion_r3617329373
##########
superset-frontend/packages/superset-ui-core/src/components/Select/Select.tsx:
##########
@@ -500,34 +514,80 @@ const Select = forwardRef(
setSelectOptions(updatedOptions);
}
- const filteredOptions = updatedOptions
- .map((option: any) => {
- /*
- If it's a group, filter its nested options and only return it
- if it has matching options
- */
- if ('options' in option && Array.isArray(option.options)) {
- const filteredGroupOptions = option.options.filter(
- (subOption: AntdLabeledValue) =>
- handleFilterOption(search, subOption),
+ const handleOnSearch = useMemo(
+ () =>
+ debounce((search: string) => {
+ const {
+ selectOptions,
+ allowNewOptions,
+ fullSelectOptions,
+ selectValue,
+ handleFilterOption,
+ onSearch,
+ } = stateRef.current;
+
+ const searchValue = search.trim();
+ setIsSearching(!!searchValue);
+
+ let updatedOptions = selectOptions;
+
+ if (allowNewOptions) {
+ const optionsWithoutTemporary = ensureIsArray(
+ fullSelectOptions,
+ ).filter(opt => !opt.isNewOption);
+ const shouldCreateNewOption =
+ searchValue &&
+ !hasOption(searchValue, optionsWithoutTemporary, true);
+
+ const newOption = shouldCreateNewOption && {
+ label: searchValue,
+ value: searchValue,
+ isNewOption: true,
+ };
+ const cleanSelectOptions = ensureIsArray(fullSelectOptions).filter(
+ opt => !opt.isNewOption || hasOption(opt.value, selectValue),
);
- return filteredGroupOptions.length > 0
- ? { ...option, options: filteredGroupOptions }
- : null;
+ updatedOptions = newOption
+ ? [newOption, ...cleanSelectOptions]
+ : cleanSelectOptions;
+ setSelectOptions(updatedOptions);
}
- return handleFilterOption(search, option as AntdLabeledValue)
- ? option
- : null;
- })
- .filter((option): option is AntdLabeledValue => option !== null);
+ const filteredOptions = updatedOptions
+ .map((option: any) => {
Review Comment:
**Suggestion:** Replace the `any` annotation with a concrete option type (or
a safe union) so the mapper is fully typed. [custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
The final file state still contains `option: any` in the new hunk, which
directly violates the no-any-types rule. Replacing it with a concrete option
type or union would satisfy the rule.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
=== .cursor/rules/dev-standard.mdc === (line 16)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=cdba48980a4a474691fed7e9838ac220&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=cdba48980a4a474691fed7e9838ac220&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/packages/superset-ui-core/src/components/Select/Select.tsx
**Line:** 557:557
**Comment:**
*Custom Rule: Replace the `any` annotation with a concrete option type
(or a safe union) so the mapper is fully typed.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F35218&comment_hash=2d181a95e01d5981c085ca55e3d98dad1daac493114afd817e3f4759458a9949&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F35218&comment_hash=2d181a95e01d5981c085ca55e3d98dad1daac493114afd817e3f4759458a9949&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
