younsl commented on PR #196: URL: https://github.com/apache/superset-kubernetes-operator/pull/196#issuecomment-5028114035
Thanks for the review @villebro! All three points addressed in aebc0a9: - **`extraManifests`**: agreed — it reads more explicitly, and kube-prometheus-stack uses the same name. Renamed everywhere (template file is now `templates/extra-manifests.yaml`, plus `values.yaml`, `values.schema.json`, and the PR title/body). - **Release notes**: added an `### Added` entry under `## Unreleased` in `docs/reference/releases.md` with your suggested wording. - **Usage guidance**: added the recommended/not-recommended note in both places — next to the examples in `values.yaml` and as a short "Extra manifests" section in `docs/user-guide/installation.md` (release-scoped companion resources like a cert-manager Certificate, NetworkPolicy, or ExternalSecret; not shared cluster infrastructure such as Gateway API controllers, CRDs, or shared Gateways). Re-verified `make helm-lint` and `helm template` for the object form, string form, and empty default after the rename. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
