rusackas commented on PR #42221: URL: https://github.com/apache/superset/pull/42221#issuecomment-5028705836
Thanks for this, Hans. Bito's thread on `api_tests.py:126` is still open, and your reply about `cascade_backrefs` doesn't quite answer whether `db.session.add_all(metrics)` is redundant given `table.metrics = metrics` then `db.session.add(table)` should cascade-save them anyway. Mind resolving that one way or another? Also, sadpandajoe's ask above for more detail in the PR description is still open, would help given this touches cascade semantics in a few places, and we do refer back to PR descriptions in various places for history. Looks like it needs a rebase too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
