rusackas commented on code in PR #42119:
URL: https://github.com/apache/superset/pull/42119#discussion_r3618519343
##########
superset/utils/screenshots.py:
##########
@@ -210,11 +210,16 @@ def driver(
return WebDriverSelenium(self.driver_type, window_size, user)
def get_screenshot(
- self, user: User, window_size: WindowSize | None = None
+ self,
+ user: User,
+ window_size: WindowSize | None = None,
+ log_context: str | None = None,
) -> bytes | None:
Review Comment:
`user: User` (and the `= None` mismatch over in `compute_and_cache`)
predates this PR... the diff just rewrapped the line for the new parameter.
Fine as a follow-up cleanup, not blocking this fix. Resolving.
##########
superset/commands/report/execute.py:
##########
@@ -564,7 +564,9 @@ def _get_screenshots(self) -> list[bytes]:
try:
imges = []
for screenshot in screenshots:
- imge = screenshot.get_screenshot(user=user)
+ imge = screenshot.get_screenshot(
+ user=user, log_context=f"execution_id={self._execution_id}"
+ )
Review Comment:
`imge`/`imges` is pre-existing naming in this function, the diff just
rewrapped the call. Renaming is churn for another day. Resolving.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
