msyavuz opened a new pull request, #42270:
URL: https://github.com/apache/superset/pull/42270

   ### SUMMARY
   
   Clicking **Stop** while a chart query runs in Explore left the chart area 
blank with no message. The Stop logic was correct — the request aborts, 
`chartUpdateStopped` dispatches, and the reducer sets `chartStatus: 'stopped'` 
with the alert `Updating chart was stopped` — but `Chart.tsx` had no render 
branch for `'stopped'`. It only handled `'failed'`, and the "ready to go" empty 
state is gated on `!chartAlert`, so every branch declined and the container 
rendered nothing.
   
   This adds an informational `EmptyState` for the stopped status that surfaces 
the existing alert and offers a re-run affordance, mirroring the neighboring 
"Your chart is ready to go!" state.
   
   Scope note: this fixes the synchronous (non-GAQ) flow. Under 
`GLOBAL_ASYNC_QUERIES` the abort is a no-op once the job is polling, so 
`'stopped'` is never set and this branch never renders — that is tracked 
separately.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Before: Stop → chart area goes blank, no message.
   After: Stop → "Updating chart was stopped" with a link to re-run.
   
   ### TESTING INSTRUCTIONS
   
   1. Create a dataset whose query runs for a few seconds (e.g. a virtual 
dataset `SELECT pg_sleep(20)`).
   2. Build a chart on it and trigger a refresh (click the `Cached` badge).
   3. Click **Stop** while it loads.
   4. The chart area shows "Updating chart was stopped" and a re-run link, 
instead of blank space.
   
   Unit test added in `Chart.test.tsx`; `npm run test -- Chart.test.tsx`.
   
   ### ADDITIONAL INFORMATION
   
   - [x] Has associated issue: No — internal tracker
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to