bito-code-review[bot] commented on code in PR #42263:
URL: https://github.com/apache/superset/pull/42263#discussion_r3623631595
##########
superset-frontend/src/features/home/SavedQueries.test.tsx:
##########
@@ -25,7 +25,7 @@ import {
waitFor,
} from 'spec/helpers/testing-library';
import fetchMock from 'fetch-mock';
-import SavedQueries from './SavedQueries';
+import ToastedSavedQueries from './SavedQueries';
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Naming inconsistency with other tests</b></div>
<div id="fix">
The import alias `ToastedSavedQueries` is inconsistent with all other test
files in this directory which import components by their direct name. This
naming (prefixed with HOC wrapper pattern) is misleading since it suggests a
distinct 'toasted' variant rather than the HOC-wrapped component. Use
`SavedQueries` instead to match the established pattern.
</div>
</div>
<small><i>Code Review Run #89c53d</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
