rusackas commented on PR #42152: URL: https://github.com/apache/superset/pull/42152#issuecomment-5036686595
Thanks @hainenber! That fallback is actually in there already... once the path list crosses ~100KB it punts to `--all-files`. The part I'd hate to lose is diffing against the live base tip. If we keep the frozen `base.sha` and just threshold it, a stale PR touching a few files still sweeps in a pile of `master` churn below the threshold, and above it every long-lived PR pays the full-tree run (and can fail on files the author never touched). With `HEAD^1` the list stays accurate, so the fallback should almost never fire, and the nightly sweep already covers the whole tree anyway. Happy to swap the byte cap for a simpler file-count threshold if that reads better. Thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
