codeant-ai-for-open-source[bot] commented on code in PR #38019:
URL: https://github.com/apache/superset/pull/38019#discussion_r3624741182
##########
superset-frontend/plugins/legacy-plugin-chart-country-map/scripts/Country Map
GeoJSON Generator.ipynb:
##########
@@ -2384,6 +2384,18 @@
"not speed_run and india_copy.plot(**plot_styles)"
]
},
+ {
+ "cell_type": "markdown",
+ "metadata": {},
+ "source": "#### Kenya\nThe administrative divisions in the Natural Earth
dataset are outdated since the 2010 constitution, see
https://en.wikipedia.org/wiki/Counties_of_Kenya. County boundary data sourced
from [geoBoundaries](https://www.geoboundaries.org) (CC BY 4.0), available on
[OCHA
HDX](https://data.humdata.org/dataset/geoboundaries-admin-boundaries-for-kenya)."
+ },
+ {
+ "cell_type": "code",
+ "execution_count": null,
+ "metadata": {},
+ "outputs": [],
+ "source": "kenya_copy = df[df.admin == 'Kenya'].copy()\n# Source:
geoBoundaries Kenya ADM1 (CC BY 4.0) via OCHA HDX\n#
https://data.humdata.org/dataset/geoboundaries-admin-boundaries-for-kenya\nkenya_geojson_url
=
\"https://github.com/wmgeolab/geoBoundaries/raw/9469f09/releaseData/gbOpen/KEN/ADM1/geoBoundaries-KEN-ADM1.geojson\"\n\ntry:\n
kenya_gdf = gpd.read_file(kenya_geojson_url)\n kenya_gdf =
kenya_gdf.rename(columns={'shapeName': 'name', 'shapeISO': 'iso_3166_2'})\n
kenya_copy = gpd.GeoDataFrame(\n kenya_gdf,\n
geometry='geometry',\n crs=kenya_gdf.crs\n )\n \n
print(\"GeoJSON file for Kenya downloaded and loaded successfully.\")\nexcept
Exception as e:\n print(f\"Unable to download or load the GeoJSON file for
Kenya. Error: {str(e)}\")\n print(\"Please download the file from the URL
and try again.\")\n\nnot speed_run and kenya_copy.plot(**plot_styles)"
Review Comment:
**Suggestion:** The error handler catches all exceptions and then continues
execution, which means Kenya will silently fall back to the old Natural Earth
geometry if the download/load fails, defeating this fix while still producing
output. Fail fast (or explicitly stop adding Kenya to the mapping) when the new
GeoJSON cannot be loaded. [logic error]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ❌ Kenya legacy country map may retain outdated boundaries.
- ⚠️ Generated Kenya GeoJSON inconsistent with 2010 counties.
- ⚠️ Notebook run appears successful despite Kenya data failure.
```
</details>
<details>
<summary><b>Steps of Reproduction ✅ </b></summary>
```mdx
1. Open the Jupyter notebook at
`superset-frontend/plugins/legacy-plugin-chart-country-map/scripts/Country
Map GeoJSON
Generator.ipynb` and run cells up to the Kenya section defined at line 2397
(cell with
`kenya_copy = df[df.admin == 'Kenya'].copy()` and the `try`/`except` around
`gpd.read_file(kenya_geojson_url)`).
2. Execute this Kenya cell in an environment where the GitHub URL
`geoBoundaries-KEN-ADM1.geojson` is unreachable (e.g., no internet or
blocked GitHub),
causing `gpd.read_file(kenya_geojson_url)` in the `try` block at line 2397
to raise an
exception.
3. Observe that the `except Exception as e:` block at line 2397 catches the
error, prints
the failure messages, and then completes the cell without modifying
`kenya_copy`, which
still holds the original Natural Earth geometry from `df[df.admin ==
'Kenya'].copy()`.
4. Run the later cell that builds the country mapping dictionary at lines
3954–3957, where
`"kenya": kenya_copy,` is added; subsequently running the export cells
(below this hunk in
the notebook) will generate GeoJSON for Kenya using the stale Natural Earth
boundaries
while the notebook execution appears successful.
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=5ddf158a981f4e8faa5d94107f117143&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=5ddf158a981f4e8faa5d94107f117143&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/plugins/legacy-plugin-chart-country-map/scripts/Country Map
GeoJSON Generator.ipynb
**Line:** 2397:2397
**Comment:**
*Logic Error: The error handler catches all exceptions and then
continues execution, which means Kenya will silently fall back to the old
Natural Earth geometry if the download/load fails, defeating this fix while
still producing output. Fail fast (or explicitly stop adding Kenya to the
mapping) when the new GeoJSON cannot be loaded.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F38019&comment_hash=98bff0756cd4576b068f3e08dca4fce942a096c91308c861fd4ade6a761316eb&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F38019&comment_hash=98bff0756cd4576b068f3e08dca4fce942a096c91308c861fd4ade6a761316eb&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
