hy144328 commented on PR #42277: URL: https://github.com/apache/superset/pull/42277#issuecomment-5038371840
@rusackas This should be ready for review, too. I am quite pleased that it caused a few cases in the integration tests where the code had regressed due to concurrent PRs, e.g. incorrect use of `engine.connect()`, which does not autocommit anymore. They were not caught because the `SQLALCHEMY_WARN_20` environment variable is only added to the unit test CI. I wonder if this would be a good time now since we bumping versions has a real chance of breaking things. Or in other words, a follow-up to #41915 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
