sadpandajoe commented on code in PR #42250:
URL: https://github.com/apache/superset/pull/42250#discussion_r3625972610
##########
superset-frontend/packages/superset-ui-core/test/query/getClientErrorObject.test.ts:
##########
@@ -336,3 +336,29 @@ test('getErrorText', async () => {
),
).toEqual('Sorry, an unknown error occurred.');
});
+
+test('getErrorText for a non-JSON 403 response', async () => {
Review Comment:
This test covers getErrorText, but saveDashboardRequest does not call this
helper—it duplicates the mapping in dashboardState.ts. Could we either test the
thunk with both 403 response shapes or refactor it to call getErrorText so a
dashboard-path regression fails this test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
