rusackas commented on PR #36350: URL: https://github.com/apache/superset/pull/36350#issuecomment-5039559702
Thanks @X-arshiya-X, still no update since my last note back in June. This is still conflicting with `master`, and the `query_model` bug I flagged is still there: in `query_context_processor.py` it's only assigned inside the `if query_obj and cache_key and not cache.is_loaded` block, but the `payload` build below references it unconditionally, so a cache hit throws `UnboundLocalError`. Also still no tests on a change touching the query lifecycle across 14 files, and the try/except signature-sniffing around `execute_with_cursor` / `execute(..., query=...)` in `models/core.py` is the kind of runtime probing I'd rather see replaced with an explicit engine-spec interface. Happy to re-review once those are sorted, but this isn't mergeable as-is, and I can't help by pushing fixes here since your for has disabled maintainer commits. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
