rusackas commented on PR #38126: URL: https://github.com/apache/superset/pull/38126#issuecomment-5039575502
@YousufFFFF checking back in here, it's been quiet since my last comment. This is still conflicting with `master` (I'll see if I can help there), and the `any` cast plus the month/year-as-fixed-days math are both still in `transformers.ts`, so shifted series will still drift out of alignment with the real dates once you get past a month or two. Let me know if you're still up for it, or I'm happy to see someone pick this up so the actual `time_shift` fix for #36966 can land using the calendar-aware logic we already have elsewhere. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
