rusackas commented on PR #36606: URL: https://github.com/apache/superset/pull/36606#issuecomment-5039665873
Thanks for the effort here, @nitishagar! I think #41184 (SIP-216) unfortunately pulls the rug out from under this one. It removes the `aggregatorName` prop entirely, since totals/subtotals become database-computed and there's no single client-side aggregator left to name. Going to close this for now, but happy to reopen (or review a fresh PR) if a label tweak still makes sense once #41184 lands. In the meantime, you're more than welcome to review/test that one... more eyes would be great! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
