bito-code-review[bot] commented on code in PR #38695:
URL: https://github.com/apache/superset/pull/38695#discussion_r3626195750
##########
superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/controlPanel.tsx:
##########
@@ -201,6 +201,30 @@ function createCustomizeSection(
},
},
],
+ [
+ {
+ name: `label_position${controlSuffix}`,
+ config: {
+ type: 'SelectControl',
+ freeForm: false,
+ label: t('Label Position'),
+ choices: [
+ ['top', t('Top')],
+ ['inside', t('Inside')],
+ ['bottom', t('Bottom')],
+ ['left', t('Left')],
+ ['right', t('Right')],
+ ],
+ default: 'top',
+ renderTrigger: true,
+ description: t(
+ 'Position of the data label relative to the bar segment',
Review Comment:
<!-- Bito Reply -->
The suggestion to change the default label position from 'top' to 'auto' is
appropriate for maintaining consistent behavior across different chart
orientations. Using 'auto' allows the charting library to dynamically determine
the optimal label placement, which prevents readability issues that can occur
when 'top' is hardcoded for horizontal bar charts.
**superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/controlPanel.tsx**
```
choices: [
['top', t('Top')],
['inside', t('Inside')],
['bottom', t('Bottom')],
['left', t('Left')],
['right', t('Right')],
],
default: 'auto',
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
