rusackas commented on code in PR #36603:
URL: https://github.com/apache/superset/pull/36603#discussion_r3626210507
##########
superset/db_engine_specs/hive.py:
##########
@@ -272,8 +272,6 @@ def adjust_engine_params(
catalog: str | None = None,
schema: str | None = None,
) -> tuple[URL, dict[str, Any]]:
- if schema:
- uri = uri.set(database=parse.quote(schema, safe=""))
return uri, connect_args
Review Comment:
Bito had a point that deleting the block dropped dynamic schema support.
It's now handled with a `USE` prequery instead (same pattern the Databricks
spec uses), so schema selection survives without rewriting the URI. Resolving.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]