rusackas commented on PR #41957: URL: https://github.com/apache/superset/pull/41957#issuecomment-5039841638
Thanks @RehanIslam09! Unfortunately this one's about to be obsoleted by SIP-216 (#41463, which just passed its vote) and the implementation in #41184. That PR removes the pivot table's Aggregation function control entirely, and totals/subtotals become database-computed at each grouping level, so there won't be a selected aggregation to show in the label. It also rewrites the same `TableRenderers.tsx` this touches, so I'll close this out to avoid conflict churn. If you're up for it, reviewing/testing #41184 would be a big help. And if the subtotal labels still need attention once it lands, a follow-up PR would be more than welcome. Thanks for this and future contributions! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
